Common-VS2019/docs/component-reviews.md

Component Review Register

<style> table th, table td { vertical-align: top; } </style>

Last updated: 2026-09-10

Component	Scope	Status	Date reviewed	Next steps	Notes
SaCommonVS.sln	Pre-migration restore, Debug build, and tests	Baseline captured; passing with warnings	2026-09-10	Pin the SDK, address the MailKit advisory, decide the Xamarin disposition, and begin the coordinated .NET 10 migration.	SDK 10.0.401 restored and built all eight projects with 110 warnings and no errors. SacsCoreUnitTests passed 94 of 94 tests. MAUI 9 Android is out of support and MAUI API obsolescence warnings are tracked in the project-specific docs.
SacsMobileMaui	Project	Tracked in project docs	2026-09-10	Continue in the project component register and topic tracker.	Project-specific findings have been moved to SacsMobileMaui/docs.
SacsStandardBase/Base/Procs/SaProcess_Base.cs	Class	In progress	2026-09-09	Complete the Process Base actions recorded in topics.md; review derived processes separately for cooperative polling.	Lifecycle state ownership and cancellation lock ordering were changed. Five focused tests pass. Remaining concerns include mixed sync/async execution, durable cancellation outcome, cancellation exception handling, disposal, and status synchronization.
SacsStandardBase/Base/Email/SaEmailConsole.cs	Class	Reviewed; action required	2026-09-08	Restore SMTP certificate validation and require the configured TLS mode. Add invalid-certificate and unavailable-TLS tests.	The current SMTP client accepts every server certificate.
SacsStandardBase/Base/Helpers/SacsEncryptionHelper.cs and SacsStandardBase/Base/Data/SacsAesIvCrypter.cs	Classes	Reviewed; action required	2026-09-08	Design a versioned authenticated-encryption format with legacy migration and tamper tests.	Current CBC encryption is unauthenticated; password-based key derivation uses a fixed salt and low iteration count.